thejayman77
a34a47fe22
"Gathering the good news…" waits on the home's startup API calls, which were all DYNAMIC → a round-trip to the residential origin every load (the occasional 2-3s linger). These responses depend only on the URL, never the session, so they're safe to share at the edge: - /api/moods, /api/categories (static config) → public, s-maxage=900 - /api/lanes, /api/families (global, data-derived counts) → public, s-maxage=120 - /api/feed → public, s-maxage=45 ONLY when shareable (no following / prefs / exclude); the following feed (reads the session) and personal filters stay private, no-store. Hard personalization boundary, explicit per-endpoint (no blanket /api/* rule). Pairs with a Cloudflare cache rule (added separately) making these paths eligible. Tests assert the global endpoints are public+s-maxage and the feed boundary (default/topic public; following/prefs/exclude private). 227 pytest. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
110 lines
4.4 KiB
Python
110 lines
4.4 KiB
Python
import json
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
from goodnews.db import connect, init_db
|
|
|
|
|
|
@pytest.fixture
|
|
def client(tmp_path, monkeypatch):
|
|
db = tmp_path / "test.sqlite3"
|
|
monkeypatch.setenv("GOODNEWS_DB", str(db))
|
|
|
|
conn = connect(db)
|
|
init_db(conn)
|
|
conn.execute("INSERT INTO sources (id, name, feed_url, trust_score) VALUES (1,'S','http://s/f',7)")
|
|
|
|
def add(aid, topic, flavor, title):
|
|
conn.execute(
|
|
"INSERT INTO articles (id, source_id, canonical_url, title, published_at, url_hash) "
|
|
"VALUES (?,1,?,?, '2026-05-30T10:00:00+00:00', ?)",
|
|
(aid, f"http://s/{aid}", title, f"h{aid}"),
|
|
)
|
|
conn.execute(
|
|
"INSERT INTO article_scores (article_id, constructive_score, agency_score, "
|
|
"human_benefit_score, cortisol_score, ragebait_score, pr_risk_score, accepted, topic, flavor) "
|
|
"VALUES (?, 7, 3, 4, 1, 0, 2, 1, ?, ?)",
|
|
(aid, topic, flavor),
|
|
)
|
|
|
|
add(1, "science", "discovery", "A quiet science discovery")
|
|
add(2, "health", "breakthrough", "Election season health update") # has avoid-able term
|
|
conn.execute("INSERT INTO daily_briefs (id, brief_date, title) VALUES (1,'2026-05-30','Brief')")
|
|
conn.execute("INSERT INTO daily_brief_items (brief_id, article_id, rank) VALUES (1,1,1),(1,2,2)")
|
|
conn.commit()
|
|
conn.close()
|
|
|
|
# Import after env is set so the app reads the temp DB.
|
|
from goodnews.api import create_app
|
|
|
|
return TestClient(create_app())
|
|
|
|
|
|
def _prefs(client, **kw):
|
|
return client.get("/api/feed", params={"prefs": json.dumps(kw)})
|
|
|
|
|
|
def test_bad_prefs_returns_200_and_full_feed(client):
|
|
r = client.get("/api/feed", params={"prefs": "not json at all"})
|
|
assert r.status_code == 200
|
|
assert r.json()["count"] == 2 # forgiving: bad blob ignored
|
|
|
|
|
|
def test_mute_topic_affects_feed(client):
|
|
r = _prefs(client, mute_topics=["science"])
|
|
topics = [i["topic"] for i in r.json()["items"]]
|
|
assert topics == ["health"]
|
|
|
|
|
|
def test_avoid_term_filters_feed(client):
|
|
r = _prefs(client, avoid_terms=["election"])
|
|
titles = [i["title"] for i in r.json()["items"]]
|
|
assert all("election" not in t.lower() for t in titles)
|
|
assert len(titles) == 1
|
|
|
|
|
|
def test_brief_filters_down_without_refill(client):
|
|
full = client.get("/api/brief").json()
|
|
assert len(full["items"]) == 2
|
|
muted = client.get("/api/brief", params={"prefs": json.dumps({"mute_topics": ["health"]})}).json()
|
|
assert [i["topic"] for i in muted["items"]] == ["science"]
|
|
|
|
|
|
def test_category_counts_match_filtered_feed(client):
|
|
counts = client.get("/api/category-counts", params={"prefs": json.dumps({"mute_topics": ["health"]})}).json()
|
|
assert all(c["topic"] != "health" for c in counts)
|
|
|
|
|
|
def test_feed_excludes_dismissed(client):
|
|
r = client.get("/api/feed", params={"exclude": "1"})
|
|
ids = [i["id"] for i in r.json()["items"]]
|
|
assert 1 not in ids
|
|
|
|
|
|
def test_families_endpoint(client):
|
|
fams = client.get("/api/families").json()
|
|
names = [f["name"] for f in fams]
|
|
assert "Discovery & Wonder" in names
|
|
assert all("tags" in f and isinstance(f["tags"], list) for f in fams)
|
|
|
|
|
|
def test_global_endpoints_are_edge_cacheable(client):
|
|
# The startup endpoints are identical for every visitor → publicly cacheable
|
|
# so "Gathering the good news…" resolves from the edge, not the origin.
|
|
for path in ("/api/moods", "/api/categories", "/api/lanes", "/api/families"):
|
|
cc = client.get(path).headers.get("cache-control", "")
|
|
assert "public" in cc and "s-maxage" in cc, f"{path}: {cc!r}"
|
|
|
|
|
|
def test_feed_cache_boundary(client):
|
|
# Shareable (URL-determined) feeds are public; personalized ones are private.
|
|
public_cc = client.get("/api/feed").headers.get("cache-control", "")
|
|
assert "public" in public_cc and "s-maxage" in public_cc
|
|
# topic/tag browse is still shareable (same for everyone)
|
|
assert "public" in client.get("/api/feed", params={"topic": "science"}).headers.get("cache-control", "")
|
|
# personal filters + the following feed must never be shared across users
|
|
assert client.get("/api/feed", params={"following": "true"}).headers.get("cache-control") == "private, no-store"
|
|
assert client.get("/api/feed", params={"prefs": json.dumps({"mute_topics": ["science"]})}).headers.get("cache-control") == "private, no-store"
|
|
assert client.get("/api/feed", params={"exclude": "1,2"}).headers.get("cache-control") == "private, no-store"
|