thejayman77/upbeatBytes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Feedback reply: release DB connection before SMTP send

Browse Source 
Per Codex: validate + gather in one short DB block, send SMTP with no
connection held (~20s), then reopen to record the reply + mark read. Better
operational hygiene; no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jay
2026-06-08 14:58:19 -04:00
parent 84fd61bf3f
commit 245b415163
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
goodnews/api.py
+9 -4
View File
@@ -845,6 +845,8 @@ def create_app() -> FastAPI:
message = (body.message or "").strip()[:4000] message = (body.message or "").strip()[:4000]
if not message: if not message:
raise HTTPException(status_code=422, detail="Reply message is required.") raise HTTPException(status_code=422, detail="Reply message is required.")
# 1. Validate + gather, then release the DB connection — SMTP can take
# ~20s and shouldn't keep a connection open.
with get_conn() as conn: with get_conn() as conn:
admin = _require_admin(conn, request) admin = _require_admin(conn, request)
fb = conn.execute("SELECT contact_email, message FROM feedback WHERE id = ?", (fid,)).fetchone() fb = conn.execute("SELECT contact_email, message FROM feedback WHERE id = ?", (fid,)).fetchone()
@@ -852,15 +854,18 @@ def create_app() -> FastAPI:
raise HTTPException(status_code=404, detail="feedback not found") raise HTTPException(status_code=404, detail="feedback not found")
if not fb["contact_email"]: if not fb["contact_email"]:
raise HTTPException(status_code=400, detail="No reply address for this feedback.") raise HTTPException(status_code=400, detail="No reply address for this feedback.")
# Send first — only record a reply that actually went out, so the UI admin_id, to, original = admin["id"], fb["contact_email"], fb["message"]
# can keep the draft on failure. # 2. Send with no DB connection held; only record a reply that actually
# went out, so the UI can keep the draft on failure.
try: try:
email_send.send_feedback_reply(fb["contact_email"], message, fb["message"]) email_send.send_feedback_reply(to, message, original)
except Exception as exc: # noqa: BLE001 — surface any SMTP failure to the admin except Exception as exc: # noqa: BLE001 — surface any SMTP failure to the admin
raise HTTPException(status_code=502, detail=f"Could not send the reply: {exc}") raise HTTPException(status_code=502, detail=f"Could not send the reply: {exc}")
# 3. Record the sent reply + mark the item read.
with get_conn() as conn:
cur = conn.execute( cur = conn.execute(
"INSERT INTO feedback_replies (feedback_id, user_id, message, sent_to) VALUES (?, ?, ?, ?)", "INSERT INTO feedback_replies (feedback_id, user_id, message, sent_to) VALUES (?, ?, ?, ?)",
(fid, admin["id"], message, fb["contact_email"]), (fid, admin_id, message, to),
) )
conn.execute( conn.execute(
"UPDATE feedback SET read_at = COALESCE(read_at, CURRENT_TIMESTAMP) WHERE id = ?", (fid,) "UPDATE feedback SET read_at = COALESCE(read_at, CURRENT_TIMESTAMP) WHERE id = ?", (fid,)