thejayman77/on_the_level
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Serialize app-scope writes via Main.immediate (Codex hardening note)

Browse Source 
Non-blocking follow-up from the audit: applicationScope ran on
Dispatchers.Default, so two very fast conflicting persistence writes
(recalibrate then immediately Reset) had no ordering guarantee. Main.immediate
launches the coroutine body synchronously in call order, so the DataStore
edits enqueue deterministically; DataStore still does the IO on its own
dispatcher. Only lightweight persistence uses this scope.

64 tests passing; assembleDebug clean; runs on device.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Jay
2026-07-14 11:21:57 -04:00
parent daf19c34b3
commit e5d15c920f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/com/onthelevel/OnTheLevelApp.kt
+6 -1
View File
@@ -22,8 +22,13 @@ class AppContainer(context: Context) {
* Outlives any single screen. Used for durable fire-and-forget persistence * Outlives any single screen. Used for durable fire-and-forget persistence
* (e.g. saving a calibration): a screen-scoped coroutine would be cancelled if * (e.g. saving a calibration): a screen-scoped coroutine would be cancelled if
* the user leaves the moment the write is launched. * the user leaves the moment the write is launched.
*
* Main.immediate (not Default) so writes launched from UI callbacks enqueue in
* call order — two fast conflicting writes (recalibrate then Reset) then reach
* DataStore deterministically. Only lightweight persistence runs here; DataStore
* still performs the actual IO on its own dispatcher.
*/ */
val applicationScope = CoroutineScope(SupervisorJob() + Dispatchers.Default) val applicationScope = CoroutineScope(SupervisorJob() + Dispatchers.Main.immediate)
val sensorSource: SensorSource by lazy { AndroidSensorSource(appContext) } val sensorSource: SensorSource by lazy { AndroidSensorSource(appContext) }
val settings: SettingsRepository by lazy { SettingsRepository(appContext) } val settings: SettingsRepository by lazy { SettingsRepository(appContext) }