Add photo attachments to parts

A bag falling apart after forty years still has the part number printed on it,
and the picture carries more than any field you could retype it into. Photos
attach from the part form; on a phone the picker opens the camera directly.

Files live beside the database in the same volume, with only metadata in SQLite
— blobs there bloat the database and complicate the VACUUM INTO backup. The
browser downscales to 2000px before uploading, honouring EXIF orientation via
createImageBitmap, which keeps an image library and its native dependencies out
of the server entirely.

Uploads are sniffed by content rather than trusted by their declared type, so a
file that merely claims to be a JPEG cannot be stored and served back from this
origin as something a browser will execute. SVG is refused for the same reason.
Reads are capped rather than trusting Content-Length, at most 12 photos per
part, and a row that fails to insert takes its file with it.

Deleting a photo or a part removes the files, not just the rows, and
`app.admin prune-images` sweeps anything a crash stranded. The README's backup
procedure now covers both halves; capturing only the database would have
silently lost every photo.

python-multipart returns for the upload, pinned at 0.0.32 — the version removed
earlier was 0.0.20, which carried advisories. Audit is clean.

Two frontend bugs surfaced while testing this in the browser: a photo count
changing left the list row stale, and the part form opened from the list's
cached copy rather than fetching current data.

Checks go from 197 to 271.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jay
2026-08-24 17:03:36 -04:00
parent 59949e91ca
commit 96d2a1a087
9 changed files with 742 additions and 26 deletions
+36 -6
View File
@@ -5,6 +5,7 @@ cannot help with — a forgotten password — and for the initial handover.
docker exec -it parts python -m app.admin set-password
docker exec parts python -m app.admin show-status
docker exec parts python -m app.admin prune-images
"""
import getpass
@@ -40,16 +41,45 @@ def clear_password(_argv):
return 0
def show_status(_argv):
def prune_images(_argv):
"""Delete image files with no row pointing at them.
Uploads write the file before the row, so an ill-timed crash can strand
one. Nothing else creates orphans; this is a sweeper, not a routine step.
"""
import os
with db.session() as conn:
stored = auth.stored_hash(conn)
print("password source :", "database (set in the app)" if stored else "PARTS_PASSWORD env var")
print("session epoch :", auth.current_epoch(conn))
print("auth enabled :", auth.auth_enabled())
known = {
os.path.basename(db.image_path(r["token"], r["mime"]))
for r in conn.execute("SELECT token, mime FROM part_images").fetchall()
}
removed = 0
for name in os.listdir(db.IMAGE_DIR):
if name not in known:
os.remove(os.path.join(db.IMAGE_DIR, name))
removed += 1
print(f"{removed} orphaned image file(s) removed; {len(known)} kept.")
return 0
COMMANDS = {"set-password": set_password, "clear-password": clear_password, "show-status": show_status}
def show_status(_argv):
import os
with db.session() as conn:
stored = auth.stored_hash(conn)
images = conn.execute("SELECT COUNT(*) AS n, COALESCE(SUM(bytes), 0) AS b "
"FROM part_images").fetchone()
print("password source :", "database (set in the app)" if stored else "PARTS_PASSWORD env var")
print("session epoch :", auth.current_epoch(conn))
print("auth enabled :", auth.auth_enabled())
print("images :", f"{images['n']} rows, {images['b'] / 1024 / 1024:.1f} MB",
f"({len(os.listdir(db.IMAGE_DIR))} files in {db.IMAGE_DIR})")
return 0
COMMANDS = {"set-password": set_password, "clear-password": clear_password,
"show-status": show_status, "prune-images": prune_images}
def main(argv=None):